fix: sip10 token default max length, closes #4930 #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
force-pushed
the
fix/sip10-max-length
branch
from
3613b8f to
6eaea3e
Compare
kyranjamie
approved these changes
Mar 11, 2024
|
Not understanding this change tbh? Why have it at all if it is Infinity? This didn't break the input field font resizing? I thought it was used in that calc? |
|
@fbwoolf yeah, it's not the best solution,I now think that could have done it better just getting max input length from users available asset balance... but current implementation doesn't make much sense at all, since we set maxLength using decimals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set sip10 token max length to Infinity, as we don't know it's decimals and num can be big